Replace parser #125
Merged
Replace parser #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
amCap1712
reviewed
Jan 30, 2024
amCap1712
reviewed
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyParsing parser was pretty powerful, but it had the worst error messages on the planet. By simplifying the syntax of LB-Radio a bit, the parser becomes a lot simpler and allows the super simple artist and tag queries that most people will use. This new parser is written in straight python and has much improved error messages, but I am sure that I've missed edge cases for things that need to be detected, but for now is is ok to merge. Before we release this into prod, we'll need to do a round of testing on beta to ensure that all is ok.